Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Official repo version behind / no PR for current version #176

Open
grnassar opened this issue Apr 27, 2022 · 5 comments
Open

Official repo version behind / no PR for current version #176

grnassar opened this issue Apr 27, 2022 · 5 comments
Labels
gog-issue Issue caused, blocked by or related to GOG Galaxy or its API

Comments

@grnassar
Copy link

Describe the bug
In other community integrations, the "official" FriendsOfGalaxy repo seems to use a bot to identify when a PR is needed, and creates one when it sees the version has been updated. (See for example https://github.com/FriendsOfGalaxy/galaxy-integration-uplay/pulls and https://github.com/FriendsOfGalaxy/galaxy-integration-rockstar/pulls) Now, GOG doesn't necessarily seem to be actually processing those PRs since January, but for some reason the Humble plugin doesn't even have a PR in the queue for its updates. (https://github.com/FriendsOfGalaxy/galaxy-integration-humble/pulls) I am guessing the bot wasn't clever enough to realize 10 > 9 (aka string or digit compare vs numerical), but that's not your problem of course :) However, you could probably do the PR manually and then... well, it could sit there waiting like the other community integrations, I guess, but at least that's another step forward!

Expected behavior
All handled downstream (don't we all wish!)

Plugin installed
directly from Galaxy / manually from your repository releases

Provide logs
n/a

@grnassar grnassar added the bug Something isn't working label Apr 27, 2022
@grnassar
Copy link
Author

obviously not a bug, can't seem to unassign label -- apologies

@grnassar
Copy link
Author

Just created an issue in the GOG API repo (closest thing I could see to where it would be applicable): gogcom/galaxy-integrations-python-api#194 in case that helps.

@UncleGoogle
Copy link
Owner

UncleGoogle commented Apr 28, 2022

Hi, thanks for raising the problem.

I am guessing the bot wasn't clever enough to realize 10 > 9

I think the issue is caused by auto-disabling github actions after 60days of no activity: https://docs.github.com/en/actions/managing-workflow-runs/disabling-and-enabling-a-workflow
so the other plugins will be affected in the future as well.

Issue on gog side is a good idea.

@UncleGoogle UncleGoogle added bug Something isn't working gog-issue Issue caused, blocked by or related to GOG Galaxy or its API and removed bug Something isn't working labels Apr 28, 2022
@grnassar
Copy link
Author

That's a great point. I overlooked that possibility.
Whatever the reason for the lack of PR, it may be a good idea (and certainly can't hurt, I'd think) to create a PR manually anyway, I think.
Thank you for your time looking into this. I hope the issue on the gog side helps. It's not technically in the "right place," and they seem to not be very responsive to issues not being raised in the right place -- even in cases, like this one, where the "right place" doesn't actually exist anymore.

@UncleGoogle
Copy link
Owner

For reference: https://github.com/FriendsOfGalaxy/galaxy-integration-humble/actions/workflows/sync.yml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gog-issue Issue caused, blocked by or related to GOG Galaxy or its API
Projects
None yet
Development

No branches or pull requests

2 participants