Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency issues when loading templates #330

Merged
merged 36 commits into from
Feb 18, 2024
Merged

Fix concurrency issues when loading templates #330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
10dc07c
Fix Pug concurrency, Expand benchmarks for Pug and HTML
gaby Jan 23, 2024
f72deed
Fix typo
gaby Jan 23, 2024
cf69da7
Revert change to view
gaby Jan 23, 2024
d5d63af
Expand benchmarks for Slim engine
gaby Jan 23, 2024
9820641
Fix Pug unit-tests
gaby Jan 24, 2024
b60cef2
Update benchmarks for Ace
gaby Jan 24, 2024
e612189
Update pug.go
gaby Jan 27, 2024
e6ea29f
Simplify pug
gaby Jan 29, 2024
302a63f
Update Slim Engine
gaby Feb 6, 2024
ab910ee
Update Mustache Engine
gaby Feb 6, 2024
4f7ab6b
Update Jet Engine
gaby Feb 7, 2024
51c1c16
Update HTML engine
gaby Feb 7, 2024
25460a2
More fixes
gaby Feb 11, 2024
7d4fe73
Run code through gofumpt
gaby Feb 11, 2024
f92c184
Update handlebars
gaby Feb 11, 2024
e1fda5a
Migrate handlebars to mailgun fork. Add go1.22, remove older go versi…
gaby Feb 11, 2024
b3c666f
Bump outdated actions
gaby Feb 11, 2024
49979f7
Run benchmarks if benchmark.yml changes
gaby Feb 11, 2024
d99b60d
Bump ace min to go1.18, update golangci-lint to v1.56.1
gaby Feb 11, 2024
8520c17
Update .golangci.yml
gaby Feb 11, 2024
82c500a
Update amber_test.go
gaby Feb 11, 2024
30eaa1a
Update django.go
gaby Feb 11, 2024
cd667ba
Merge branch 'master' into expand-bench-tests
gaby Feb 12, 2024
40a22b5
Merge branch 'master' into expand-bench-tests
gaby Feb 13, 2024
d73cd8d
Merge branch 'master' into expand-bench-tests
gaby Feb 14, 2024
06ea1af
Update go.mod for Ace. Update README
gaby Feb 15, 2024
ca3e082
Merge branch 'expand-bench-tests' of github.com:gofiber/template into…
gaby Feb 15, 2024
b82f011
Remove all breaking changes
gaby Feb 18, 2024
3f5bad6
Fix issue with HTML engine
gaby Feb 18, 2024
4b18635
Rename Concurrent to Parallel
gaby Feb 18, 2024
3e12de7
Rename function and add comment
gaby Feb 18, 2024
caf252a
Fix ace go.mod file
gaby Feb 18, 2024
826af69
Remove defer
gaby Feb 18, 2024
c1bc339
Merge branch 'master' into expand-bench-tests
gaby Feb 18, 2024
1421936
Add comment about mutex.unlock() vs defer
gaby Feb 18, 2024
e5747a5
Merge branch 'expand-bench-tests' of github.com:gofiber/template into…
gaby Feb 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,14 @@ on:
paths:
- "**.go"
- "**/go.mod"
- ".github/workflows/benchmark.yml"
pull_request:
branches:
- "*"
paths:
- "**.go"
- "**/go.mod"
- ".github/workflows/benchmark.yml"

permissions:
deployments: write
Expand All @@ -31,6 +33,7 @@ jobs:
with:
# NOTE: Keep this in sync with the version from go.mod
go-version: "1.20.x"
cache: false

- name: Run Benchmarks
run: |
Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/golangci-lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ on:

permissions:
contents: read
pull-requests: read
checks: write

jobs:
golangci-lint:
Expand All @@ -33,8 +35,9 @@ jobs:
with:
# NOTE: Keep this in sync with the version from go.mod
go-version: '1.20.x'
cache: false
- name: golangci-lint
uses: golangci/golangci-lint-action@v4
with:
# NOTE: Keep this in sync with the version from .golangci.yml
version: 'v1.52.2'
version: 'v1.56.2'
2 changes: 1 addition & 1 deletion .github/workflows/gosec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
with:
fetch-depth: 0
- name: Changed Files
uses: tj-actions/changed-files@v41
uses: tj-actions/changed-files@v42
id: changed-files
with:
files_ignore: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-ace.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-amber.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-django.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-handlebars.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-html.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-jet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-mustache.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-pug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-slim.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ jobs:
- 1.19.x
- 1.20.x
- 1.21.x
- 1.22.x
platform: [ ubuntu-latest, windows-latest ]
runs-on: ${{ matrix.platform }}
steps:
Expand Down
Loading
Loading