Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix concurrency issues when loading templates #330

Merged
merged 36 commits into from
Feb 18, 2024
Merged

Fix concurrency issues when loading templates #330

merged 36 commits into from
Feb 18, 2024

Conversation

gaby
Copy link
Member

@gaby gaby commented Jan 23, 2024 •
edited
Loading

Fixes #339

@gaby gaby marked this pull request as ready for review February 11, 2024 01:34
@gaby gaby requested a review from nickajacks1 February 11, 2024 01:59
nickajacks1
nickajacks1 reviewed Feb 11, 2024
View reviewed changes
Copy link
Member

@nickajacks1 nickajacks1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few comments+questions.
Not too familiar with this project or templating, so I may have missed stuff.

.golangci.yml Outdated Show resolved Hide resolved
template.go Outdated Show resolved Hide resolved
ace/ace_test.go Show resolved Hide resolved
amber/amber_test.go Outdated Show resolved Hide resolved
django/django.go Outdated Show resolved Hide resolved
django/django_test.go Show resolved Hide resolved
template.go Outdated Show resolved Hide resolved
@gaby gaby requested a review from nickajacks1 February 11, 2024 05:10
ReneWerner87
ReneWerner87 requested changes Feb 14, 2024
View reviewed changes
Copy link
Member

@ReneWerner87 ReneWerner87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adjustments due to the versions still need to be done

.github/workflows/test-ace.yml Outdated Show resolved Hide resolved
.github/workflows/test-amber.yml Outdated Show resolved Hide resolved
.github/workflows/test-django.yml Outdated Show resolved Hide resolved
.github/workflows/test-handlebars.yml Outdated Show resolved Hide resolved
.github/workflows/test-html.yml Outdated Show resolved Hide resolved
.github/workflows/test-mustache.yml Outdated Show resolved Hide resolved
.github/workflows/test-pug.yml Outdated Show resolved Hide resolved
.github/workflows/test-slim.yml Outdated Show resolved Hide resolved
ace/go.mod Outdated Show resolved Hide resolved
template.go Outdated Show resolved Hide resolved
@gaby
Copy link
Member Author

gaby commented Feb 15, 2024

adjustments due to the versions still need to be done

All done

@gaby gaby mentioned this pull request Feb 16, 2024
Closed
3 tasks
@gaby gaby changed the title Expand Benchmarks for all Template Engines Fixes to concurrency issues when loading templates Feb 18, 2024
@gaby gaby added ☢️ Bug Something isn't working and removed 🧹 Updates ❗ BreakingChange labels Feb 18, 2024
@gaby
Copy link
Member Author

gaby commented Feb 18, 2024

@ReneWerner87 @efectn @sixcolors Breaking changes have been removed :-)

@gaby gaby changed the title Fixes to concurrency issues when loading templates Fix for concurrency issues when loading templates Feb 18, 2024
@gaby gaby changed the title Fix for concurrency issues when loading templates Fix concurrency issues when loading templates Feb 18, 2024
@ReneWerner87 ReneWerner87 merged commit 9ef37f6 into master Feb 18, 2024
122 checks passed
@gaby gaby deleted the expand-bench-tests branch February 22, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneWerner87 ReneWerner87 ReneWerner87 approved these changes

@nickajacks1 nickajacks1 nickajacks1 approved these changes

@sixcolors sixcolors Awaiting requested review from sixcolors

@Fenny Fenny Awaiting requested review from Fenny

@efectn efectn Awaiting requested review from efectn

Assignees
No one assigned
Labels
☢️ Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug]: request fail before the template is available
3 participants
@gaby @ReneWerner87 @nickajacks1