Move singleton StringName definitions to header #99984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
negative_diff_but_it's_deleting_whole_files
branch
2 times, most recently
from
7082e31 to
98a52c6
Compare
KoBeWi
force-pushed
the
negative_diff_but_it's_deleting_whole_files
branch
from
98a52c6 to
d3c9bee
Compare
akien-mga
approved these changes
Dec 6, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CoreStringNames, SceneStringNames and EditorStringNames are declared in the header and then defined in cpp file. For no reason actually, because you can define them in place. Since cpp files only have the definitions, moving them to the header allowed deleting the files completely. This has a couple advantages:
const.SceneStringNames order was a mess, so I also rearranged it a bit. I also fixed inconsistency in how some methods were implemented.