-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ColorPicker: fix OKHSL circle in HSV mode #99461
base: master
Are you sure you want to change the base?
Conversation
2f2bbb9
to
e101311
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to fixing the issue, I think it should be allowed to use other color wheels in okhsl mode, not just okhsl circle. If possible I would like to update this PR, or I will open a new PR after this merges. |
Please add the modes in a separate pr! 👍 |
e101311
to
d6170f3
Compare
d6170f3
to
f6751d8
Compare
#99515 should make it easier to add new shapes. |
Actually in my test, after this pr, we just need to remove the Of course, the refactoring is great and necessary. |
Fixes #68286.
OKHSL and HSV are different things, they should be stored separately in different fields.