Add InputMap.is_builtin_action()
#98482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Oct 25, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
I suggest adding some unit tests to tests/test_input_event.h after line 98:
CHECK(InputMap::get_singleton()->is_builtin_action("ui_accept"), true);
CHECK(InputMap::get_singleton()->is_builtin_action("ui_text_submit"), true);
CHECK(InputMap::get_singleton()->is_builtin_action("ui_this_is_not_builtin"), false);
CHECK(InputMap::get_singleton()->is_builtin_action("move_forward"), false);
CHECK(InputMap::get_singleton()->is_builtin_action(""), false);
timothyqiu
force-pushed
the
builtin-actions
branch
from
105805e to
c04e105
Compare
|
Tests added. |
|
I think |
Result searching for Footnotes
|
Mickeon
reviewed
Dec 3, 2024
timothyqiu
force-pushed
the
builtin-actions
branch
from
c04e105 to
b30e04d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#11016
This PR:
is_builtin_action()to check if a name is the name of a built-in action.erase_action()warn about removing a built-in action.default_builtin_cacheanddefault_builtin_with_overrides_cachemutable since caches are expected to be modified in const methods.