Add iOS virtual controller support #97530
Open
+641
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruvzg
reviewed
Sep 27, 2024
|
@bruvzg Thank you for your review. We have another idea that could work better:
What do you think? |
That's probably OK as well. |
rolandvigh
force-pushed
the
ios_virtual_controller
branch
2 times, most recently
from
4d04acd to
8f19e30
Compare
|
We implemented the proposed changes, please take a look. |
rolandvigh
force-pushed
the
ios_virtual_controller
branch
4 times, most recently
from
af06459 to
9090de7
Compare
rolandvigh
force-pushed
the
ios_virtual_controller
branch
from
9090de7 to
7903c5f
Compare
Mickeon
reviewed
Dec 3, 2024
Co-authored-by: Micky <[email protected]>
bruvzg
approved these changes
Jan 6, 2025
AThousandShips
approved these changes
Jan 6, 2025
| /* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */ | ||
| /**************************************************************************/ | ||
|
|
||
| #import "virtual_controller_ios.h" |
There was a problem hiding this comment.
Suggested change
| #import "virtual_controller_ios.h" | |
| #import "virtual_controller_ios.h" | |
| void IOSVirtualController::controller_connected() { | ||
| if (@available(iOS 15.0, *)) { | ||
| if (gcv_controller != nil) { | ||
| BOOL hasPhysicalController = NO; |
There was a problem hiding this comment.
Suggested change
| BOOL hasPhysicalController = NO; | |
| BOOL has_physical_controller = NO; |
Please use snake_case
Comment on lines
+7
to
+9
| Use a virtual controller to display software controls that you can customize over your game. | ||
| You create a virtual controller from a configuration where you choose the input elements to display. | ||
| When you connect the controller to the device, users interact with it similarly to a real controller. |
There was a problem hiding this comment.
Suggested change
| Use a virtual controller to display software controls that you can customize over your game. | |
| You create a virtual controller from a configuration where you choose the input elements to display. | |
| When you connect the controller to the device, users interact with it similarly to a real controller. | |
| Use a virtual controller to display software controls that you can customize over your game. You create a virtual controller from a configuration where you choose the input elements to display. When you connect the controller to the device, users interact with it similarly to a real controller. |
Each new line is a separate paragraph, I think this should be one line
| /**************************************************************************/ | ||
|
|
||
| #import "core/input/virtual_controller.h" | ||
| #import <GameController/GameController.h> |
There was a problem hiding this comment.
Suggested change
| #import <GameController/GameController.h> | |
| #import <GameController/GameController.h> |
Group includes
| void connect_controller(); | ||
| void disconnect_controller(); | ||
| void initialize(); | ||
| void elements_changed(GCInputElementName name, bool hidden); |
There was a problem hiding this comment.
Suggested change
| void elements_changed(GCInputElementName name, bool hidden); | |
| void elements_changed(GCInputElementName p_name, bool p_hidden); |
Prefix arguments with p_
| enabled_button_y = GLOBAL_GET("input_devices/virtual_controller/ios/enable_button_y"); | ||
| } | ||
|
|
||
| void IOSVirtualController::elements_changed(GCInputElementName name, bool hidden) { |
There was a problem hiding this comment.
Suggested change
| void IOSVirtualController::elements_changed(GCInputElementName name, bool hidden) { | |
| void IOSVirtualController::elements_changed(GCInputElementName p_name, bool p_hidden) { |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds iOS virtual controller support to Godot.
The virtual controller may be configured in the project settings.
Apple reference: https://developer.apple.com/documentation/gamecontroller/gcvirtualcontroller?language=objc
Developed by Migeran, sponsored by Xibbon Inc.