Wayland: Use suspended event only if supported #97480
Open
+25
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hold on, forgot to add an |
In a previous PR I made an oversight and checked for the new `suspended` event even on legacy compositors, breaking suspension for them. This patch goes trough the trouble of checking for the xdg_toplevel version and seeing whether we have to use one method or the other.
Riteo
force-pushed
the
why-is-suspension-so-hard
branch
from
5ef07b9
to
45ea051
Compare
|
Ready for reaview! (Yes it was that easy :P ) |
|
(Sorry for the double post) Although this PR is ready for review I want to point out that it still needs some testing on the "smarter" compositors like kwin. As you all might have noticed I'm extremely chaotic lately so I might be able to test it myself but no guarantees. External testers are appreciated :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Might fix #96942.
In a previous PR I made an oversight and checked for the new
suspendedevent even on legacy compositors, breaking suspension for them.1This patch goes trough the trouble of checking for the
xdg_toplevelversion and seeing whether we have to use one method or the other.This also gets rid of the heuristic on "modern" (xdg_toplevel >= 6) compositors.
Needs testing as I only tested it properly on sway, which does not support said event and I don't want to mess this feature again.
Let's see if third time's the charm (might be more depending on how you count it :P ).
Footnotes
It suspended, that worked, but it then immediately unsuspended, and so on. ↩