Fix is_playing on AudioStreamPlaybackInteractive when the last clip is done
#97366
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:audio
cherrypick:4.3
cesarizu
force-pushed
the
interactive_music_is_playing
branch
from
c219387 to
67f05e9
Compare
adamscott
reviewed
Dec 4, 2024
cesarizu
force-pushed
the
interactive_music_is_playing
branch
from
4b7bd1b to
365a076
Compare
cesarizu
force-pushed
the
interactive_music_is_playing
branch
from
365a076 to
eb8c470
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing some clips with
AudioStreamPlaybackInteractive,is_playingis never set to false, even when the last clip is done playing. This PR fixes that.