Fix polygon node losing its UV toolbar #96466
Merged
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod when assinging a node. Fixes godotengine#96238
object71
force-pushed
the
fix-polygon-editor-losing-toolbar-96238
branch
from
da0683b
to
dabeaa6
Compare
AThousandShips
changed the title
KoBeWi
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
I find it weird that only this editor is affected. Also the fix isn't really correct, because make_visible() should be called automatically together with edit().
Then again, seems like every editor handles this differently, so we should standardize it somehow. For now it's probably fine like this.
akien-mga
added
the
cherrypick:4.3
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96238
Found out that the toolbar remains hidden since it is being hidden on the node_removed event.