Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PathFollow3D update transform immediately by default #96140

Merged
merged 1 commit into from
Sep 11, 2024
Merged

PathFollow3D update transform immediately by default #96140

merged 1 commit into from
Sep 11, 2024

Conversation

xiongyaohua
Copy link
Contributor

Fix #95612

@xiongyaohua xiongyaohua requested a review from a team as a code owner August 27, 2024 01:45
@AThousandShips AThousandShips added this to the 4.4 milestone Aug 27, 2024
akien-mga
akien-mga reviewed Aug 27, 2024
View reviewed changes
scene/3d/path_3d.h Outdated Show resolved Hide resolved
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Aug 27, 2024
@kleonc
Copy link
Member

kleonc commented Aug 27, 2024

Fix #95612

Tested and confirmed.

@kleonc kleonc mentioned this pull request Aug 27, 2024
Open
@kleonc kleonc force-pushed the path_follow_3d_update_transform_immediately branch from 9527203 to 51b8b74 Compare September 10, 2024 08:42
@kleonc kleonc requested a review from a team as a code owner September 10, 2024 08:42
@kleonc
Copy link
Member

kleonc commented Sep 10, 2024

Rebased, made the transforms update immediately, removed deferred path (as suggested in #96140 (comment)), added some property guards to prevent unnecessary updates.

@adamscott adamscott mentioned this pull request Sep 10, 2024
Closed
@akien-mga akien-mga merged commit 6162312 into godotengine:master Sep 11, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@wirelessfuture wirelessfuture mentioned this pull request Sep 11, 2024
Closed
@akien-mga
Copy link
Member

Cherry-picked for 4.3.1.

@akien-mga akien-mga removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Sep 16, 2024
@xiongyaohua
Copy link
Contributor Author

@kleonc Thank you for completing this. Been quite busy lately, and really appreciate your help!

@Steinbeuge Steinbeuge mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleonc kleonc kleonc left review comments

@akien-mga akien-mga akien-mga approved these changes

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
bug regression topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

PathFollow3D progress and progress_ratio properties not working after upgrading from 4.2.2 to 4.3
5 participants
@xiongyaohua @kleonc @akien-mga @adamscott @AThousandShips