Add 3D skeleton preview to Advanced Importer #96094
Merged
+113
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaracenOne
force-pushed
the
add_3d_skeleton_to_advanced_importer
branch
from
8ceaf0e
to
6de60e0
Compare
When an imported model Skeleton3D type node is selected, the bones are drawn using lines or octahedrons to provide a clearer reference to their position. Refactored Skeleton3DGizmoPlugin::redraw now uses a static function to generate bone meshes
SaracenOne
force-pushed
the
add_3d_skeleton_to_advanced_importer
branch
from
6de60e0
to
f0f9a57
Compare
fire
approved these changes
Sep 3, 2024
|
@jeronimo-schreyer Feel free to test if you want, since this is an updated version of your old pr. |
|
Sure, I can test on Windows 10 and Linux Manjaro 24. Also test changes proposed by @AThousandShips |
Better size calculation in advanced importer preview. Uses the skeleton mesh to calculate the scene's bounding box. This improves some situations where a mesh instances' scale does not match its visual representation when a skeleton is applied. Advanced importer skeletal preview UX improvement. Make the visibility of the skeletal preview in the advanced importer when selecting an animation dependent on a new dedicated toggle button rather than carrying over whether a skeletal node was or was not previously selected before selecting the animation. Advanced importer skeletal preview fix. Fixes the preview on scaled skeletons in the advanced importer by applying the node's scale to the preview and generating a skin for it.
SaracenOne
force-pushed
the
add_3d_skeleton_to_advanced_importer
branch
from
f0f9a57
to
6532eff
Compare
|
I've implemented @AThousandShips' changes, so this should be good to merge now unless anyone has any additional changes to request. |
|
I reran the failed integration test job |
AThousandShips
approved these changes
Sep 7, 2024
|
Thanks! |
akien-mga
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rebases and extends the earlier PR by @jeronimo-schreyer with the following additions: