Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up Viewport's forced_mouse_focus #95902

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Aug 21, 2024

The EditorObjectSelector::_show_popup called PopupMenu::take_mouse_focus, which called Viewport::pass_mouse_focus_to, which did nothing because the _show_popup is only called on left mouse button release and there is no mouse_focus set when the mouse is released. Since that was the only usage these methods were removed.

Viewport::pass_mouse_focus_to is the only place thatgui.forced_mouse_focus is set to true, so it is also removed.

@KoBeWi KoBeWi modified the milestones: 4.x, 4.4 Sep 3, 2024
@akien-mga akien-mga merged commit e2dd56b into godotengine:master Sep 3, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants