Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override error with _reload_scripts in ScriptLanguageExtension #95771

Closed
wants to merge 1 commit into from

Conversation

Naros
Copy link
Contributor

@Naros Naros commented Aug 18, 2024

Fixes #95770

Error:

ERROR: Required virtual method MyLanguage::_reload_scripts must be overridden before calling.
   at: _gdvirtual__reload_scripts_call (./core/object/script_language_extension.h:589)

This blocks the ability for any custom language extension to hot reload scripts.

@Naros Naros requested review from a team as code owners August 18, 2024 20:55
@Calinou Calinou added bug topic:gdextension cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 18, 2024
@Calinou Calinou added this to the 4.4 milestone Aug 18, 2024
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh goodness me, that's so many unfilled descriptions. It hurts my soul.

@Naros
Copy link
Contributor Author

Naros commented Aug 18, 2024

Oh goodness me, that's so many unfilled descriptions. It hurts my soul.

Ya well, the extension classes were never documented; though it's on my radar to do it as time permits 😁

@raulsntos
Copy link
Member

Looks like a PR for this already exists:

@akien-mga akien-mga requested a review from a team August 19, 2024 10:05
@akien-mga
Copy link
Member

Indeed, duplicate of #95730.

@akien-mga akien-mga closed this Aug 19, 2024
@akien-mga akien-mga added archived and removed cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Aug 19, 2024
@akien-mga akien-mga removed this from the 4.4 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required virtual method ScriptLanguageExtension::_reload_scripts must be overidden
5 participants