Expand the range of gamepad button keycodes to be consistent with SDL#95698
Closed
Rindbee wants to merge 1 commit intogodotengine:masterfrom
Closed
Expand the range of gamepad button keycodes to be consistent with SDL#95698Rindbee wants to merge 1 commit intogodotengine:masterfrom
Rindbee wants to merge 1 commit intogodotengine:masterfrom
Conversation
Rindbee
changed the title
Rindbee
force-pushed
the
expand-gamepad-keycode-range-on-linux
branch
from
da6b64f to
8ef2c3d
Compare
Rindbee
force-pushed
the
expand-gamepad-keycode-range-on-linux
branch
from
8ef2c3d to
7e21d86
Compare
Rindbee
force-pushed
the
expand-gamepad-keycode-range-on-linux
branch
from
7e21d86 to
f89706e
Compare
Rindbee
force-pushed
the
expand-gamepad-keycode-range-on-linux
branch
from
f89706e to
8190fc4
Compare
AThousandShips
changed the title
Recently I was testing another PR (godotengine#95486). Although some devices use the mapping scheme in `core/input/gamecontrollerdb.txt`, the mapping of some keys still fails. By using `evemu-record` to test the buttons, it is found that the key codes of some buttons are not in the range of Godot test. Comparing the SDL code, it is found that the test ranges of the two are inconsistent. This may be the reason why some devices cannot work properly in Godot.
Rindbee
force-pushed
the
expand-gamepad-keycode-range-on-linux
branch
from
8190fc4 to
331b7a0
Compare
Contributor
Author
|
This PR is no longer needed since #106218 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently I was testing another PR (#95486).
Although some devices use the mapping scheme in
core/input/gamecontrollerdb.txt, the mapping of some keys still fails.By using
evemu-recordto test the buttons, it is found that the key codes of some buttons are not in the range of Godot test. Comparing the SDL code, it is found that the test ranges of the two are inconsistent. This may be the reason why some devices cannot work properly in Godot.The guid of the mapping scheme used by the device is
050000005e040000fd02000003090000. The back button corresponds toKEY_BACKand the guide button corresponds toKEY_HOMEPAGE. I'm not sure if this is due to the device being unofficial.Faulty device:
050000005e040000fd02000003090000,Xbox One Controller (third-party manufacturer, not original)godot/core/input/gamecontrollerdb.txt
Line 1718 in 24d7451
devinfo.txt
There are buttons that send
KEY_HOMEPAGE,KEY_BACKevents.