Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macOS] Remove kill override. #95295

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[macOS] Remove kill override. #95295

merged 1 commit into from
Aug 9, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Aug 8, 2024

Partially reverts #94978, unlike is_process_running generic Unix kill is working with bundled apps, and macOS terminate seems to be slower.

Fixes #95289

@bruvzg bruvzg requested a review from a team as a code owner August 8, 2024 18:41
@bruvzg bruvzg added this to the 4.4 milestone Aug 8, 2024
@akien-mga akien-mga modified the milestones: 4.4, 4.x, 4.3 Aug 8, 2024
@akien-mga akien-mga merged commit 088065c into godotengine:master Aug 9, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:macos topic:porting
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Slowness when closing game window on Godot 4.3.rc3
2 participants
@bruvzg @akien-mga