Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android editor] Fix issue with importing projects #95086

Conversation

m4gr3d
Copy link
Contributor

@m4gr3d m4gr3d commented Aug 2, 2024

The issue was introduced by #94113:

The tentative fix checks whether project_path is empty, and if so uses to the default project path instead, matching the previous behavior. There are other options available (e.g: initializing project_path's value in the constructor instead) so feedback are welcome.

We could also revert the other PR, but it may be preferable to fix forward instead since reverting would reintroduce the issue it was addressing.

Fixes #94570

@Hilderin
Copy link
Contributor

Hilderin commented Aug 3, 2024

I tested on my Android with the artifact from this PR and the problem is fixed.

I'm not familiar with the logic for the default project path also, but the code looks good to me.

@akien-mga
Copy link
Member

FYI @jsjtxietian @KoBeWi

@akien-mga akien-mga merged commit eabeafd into godotengine:master Aug 6, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@m4gr3d m4gr3d deleted the fix_import_button_not_showing_directories branch August 6, 2024 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android Editor] Import button does not show folder content until Create button is pressed
3 participants