-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ResourceLoader is not printing a resource path on loading when verbose_stdout
is enabled
#94920
Fix ResourceLoader is not printing a resource path on loading when verbose_stdout
is enabled
#94920
Conversation
Please open an issue to track and discuss this (things like if the documentation should be changed instead, if we want to print this) |
This feature is useful when trying to track how many resources have been loaded at the moment. I don't see a reason why this feature should be removed anywhere. The only reason I thought was about the thread issue. However, the PR I mentioned has no intention of removing this feature. But if I don't give enough information or anyone would like to track this, I will create an issue for this PR ASAP. |
It seems I removed it while overhauling the former code. I don't remember if it was by mistake or purposedly. Regardless, I don't see harm in it being taken back if some found it useful and so are now missing it. That said, I'm a bit unsure about how useful that is for your stated goal:
It'd be interesting to know what you need exactly, because it may warrant opening a proposal anyway, besides this PR. |
I currently have no idea what to describe in a proposal right now. And I don't know why this had existed at first. Only I knew it helped me track if there were unwanted resources to be loaded at the time, like, Many resources in a main scene are trying to load at the same time and freezing the main thread and causing a stutter. I believe there is a better solution and more usability. For example, a new profiler about resource allocation (likely related to godotengine/godot-proposals#8143). And it may boost efficiency in visualization e.g. treemap or something like that. I also already asked about my brief problem in Rocket chat. But no one seems to be able to reply to me. Therefore this one already fits my needs. So, I hope this can be used "temporarily" before the real solution comes. At least, make it able to work for the next release that'll come in a few days. |
Really need this feature for debugging. |
It's a regression from 4.1 so it isn't critical |
Needs rebase. |
e16db9e
to
bfb5570
Compare
Thanks! |
Cherry-pick for 4.3 included in #96606. |
Fixes the issue from this post.
When any resource is going to be loaded and has the
verbose_stdout
setting enabled, the resource loader printsLoading resource: <resource path>
(andFailed loading resource
if failed). But after 4.1, this resource loader doesn't print it anymore.The current version of the
ProjectSettings
document page confirmed that theverbose_stdout
does this."Print more information to standard output when running. It displays information such as memory leaks, which scenes and resources are being loaded, etc . . ."
This feature was working until #74405 merged. So, This may be a regression.