Blender import: Correct exit code on Python exception #94873
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Blender direct import, it executes some Python but does not check if it succeeded.
godot/modules/gltf/editor/editor_import_blend_runner.cpp
Lines 84 to 93 in 607b230
Which goes to
start_blender(...)and exitcode is checked to determine failure.godot/modules/gltf/editor/editor_import_blend_runner.cpp
Lines 161 to 175 in 607b230
However, Blender does not return exitcode 1 when the Python script fails: blender/issues/82494
There is
--python-exit-codewhich returns the exitcode in the given value whenever the script fails:This PR adds the flag, as well as print the stderr of the Blender process for more clarity.