Revert "GDScript: Fix common mismatched external parser errors" #94723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c75225f. This caused a crashing regression for multiple users: godotengine#94617 (comment)
This was referenced Jul 25, 2024
|
@akien-mga : I can confirm problem mentionned here : #94691 (comment), disappeared with this revert. Strangely the 2 commits just before did not produced the error even if they contain the fix, but is present after that mentionned commit I tested several time (from artifact DL). |
|
Maybe an artifact upload bug with github itself ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c75225f.
This caused a crashing regression for multiple users: #94617 (comment)
I'd usually wait a couple of days for a regression fix so we don't need to revert what was otherwise also a regression fix, but I'm preparing to build 4.3.rc1 today (actually yesterday, but the regression threw a wrench into these plans), and the new bug is worse than #94244 in the short term.
A new PR addressing #94244 should make sure to test the cases in the regression MRPs into account:
#94617 (comment)
#94697 (comment)