Autocompletion: Register depended parsers with the main parser #94424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HolonProduction
force-pushed
the
completion-fix-depended-parsers
branch
from
43a7a3d
to
73f9fac
Compare
akien-mga
changed the title
AThousandShips
approved these changes
Jul 18, 2024
HolonProduction
force-pushed
the
completion-fix-depended-parsers
branch
from
73f9fac
to
4699e69
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94366 (I hope 🤞 have tried for a while and wasn't able to reproduce the crash anymore.)
Seems also to fix #92527 which seems very similar to #94366 with the crash being the difference. I suspect that this issue might also trigger a crash in rare occasions but haven't tested it.
Fixes #92527