Fix audio samples not being able to be "finished" #94268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Jul 17, 2024
akien-mga
reviewed
Jul 17, 2024
adamscott
force-pushed
the
fix-web-sample-playback-finished-signal-redux
branch
from
ef118b7
to
42423d9
Compare
adamscott
force-pushed
the
fix-web-sample-playback-finished-signal-redux
branch
from
42423d9
to
2f5f84b
Compare
|
Thanks! |
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94226 about issues with
AudioStreamPlayer.playingalways beingtrueonce started.Now, with this PR, I keep a list of currently playing samples and remove them of the list when stopped or when receiving the "finished" callback.