-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add some notes about native file dialog limitations. #94161
Conversation
doc/classes/FileDialog.xml
Outdated
</member> | ||
<member name="current_dir" type="String" setter="set_current_dir" getter="get_current_dir"> | ||
The current working directory of the file dialog. | ||
[b]Note:[/b] This property might be ignored by native file dialogs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This note is way too broad and, from the reader's point of view, it's meaningless. If anything, it implies the property is unreliable and you shouldn't use it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it implies the property is unreliable and you shouldn't use it.
It is unreliable.
For the reference, description for the underlying native implementation docs:
Suggested folder from which the files should be opened.
The portal implementation is free to ignore this option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's worth briefly explaining why that's the case, then, instead of leaving the reader on its own thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Agree with Mickeon about the note that could be made clearer.
Thanks! |
No description provided.