Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add some notes about native file dialog limitations. #94161

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jul 10, 2024

No description provided.

@bruvzg bruvzg added this to the 4.3 milestone Jul 10, 2024
@bruvzg bruvzg requested a review from a team as a code owner July 10, 2024 06:29
doc/classes/FileDialog.xml Outdated Show resolved Hide resolved
doc/classes/FileDialog.xml Outdated Show resolved Hide resolved
</member>
<member name="current_dir" type="String" setter="set_current_dir" getter="get_current_dir">
The current working directory of the file dialog.
[b]Note:[/b] This property might be ignored by native file dialogs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This note is way too broad and, from the reader's point of view, it's meaningless. If anything, it implies the property is unreliable and you shouldn't use it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it implies the property is unreliable and you shouldn't use it.

It is unreliable.

For the reference, description for the underlying native implementation docs:

Suggested folder from which the files should be opened.
The portal implementation is free to ignore this option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth briefly explaining why that's the case, then, instead of leaving the reader on its own thoughts.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me overall. Agree with Mickeon about the note that could be made clearer.

@akien-mga akien-mga merged commit c0fae76 into godotengine:master Jul 22, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants