Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCons: Don't override cl flags on msvc #94078

Merged
merged 1 commit into from
Jul 22, 2024
Merged

SCons: Don't override cl flags on msvc #94078

merged 1 commit into from
Jul 22, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Jul 8, 2024

Fixes an issue mentioned in #91883, where using msvc overwrites a handful of command-line build flags.

@Repiteo Repiteo added this to the 4.3 milestone Jul 8, 2024
@Repiteo Repiteo requested a review from a team July 8, 2024 15:04
@Repiteo Repiteo requested a review from a team as a code owner July 8, 2024 15:04
@akien-mga akien-mga merged commit a50fe87 into godotengine:master Jul 22, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the scons/msvc-flag-fix branch July 22, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:buildsystem
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@Repiteo @akien-mga