Fix first time of Toggle Last Opened Bottom Panel opens Output panel #94040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
approved these changes
Jul 7, 2024
There was a problem hiding this comment.
Tested locally, it works as expected.
PS: I noticed that when you move the FileSystem dock back to the side, pressing Ctrl + J won't toggle the Output panel (which then becomes the first bottom panel on the list). Nothing will happen when pressing Ctrl + J, which feels strange. This issue also occurs in master.
|
Thanks for testing! I'll probably look into this issue a bit later today. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main problem was that le
FileSystemDockwas not the first inEditorBottomPanel::itemseven if the button was.Also, the visibility of the moved panel at the bottom was set to visible even if they were not supposed on editor startup. That was causing problem when calling
_switch_to_itemto display theFileSystemDock, it was already visible so the function exited early making the panel not resizable and the toggle not working.