-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.2] Make an early return when rendering buffer failed to allocate instead… #93911
[4.2] Make an early return when rendering buffer failed to allocate instead… #93911
Conversation
GHA / 📊 Static checks / Code style, file formatting, and docs (pull_request) seems to be complaining about some part of the file that was not modified by this PR (it wants to change an #include) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I pushed a fix for the static checks issue in the
Is the There's little point in fixing a bug in 4.2 only if we're about to release 4.3 with the same bug. |
For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info. |
Also, regarding 4.3+ all those error checks are performed driver-agnostically at |
6590e72
to
93fa217
Compare
93fa217
to
63be8ec
Compare
Rebased
Fixed |
Thanks! |
This PR is sponsored by Prehensile Tales and the MSEP.one project
This unhandled errors caused a crash if not caught.
master
branch has changed too much from 4.2.x to make a pull request to it tho