Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Make an early return when rendering buffer failed to allocate instead… #93911

Merged

Conversation

MarianoGnu
Copy link
Contributor

This PR is sponsored by Prehensile Tales and the MSEP.one project

This unhandled errors caused a crash if not caught. master branch has changed too much from 4.2.x to make a pull request to it tho

@MarianoGnu MarianoGnu requested a review from a team as a code owner July 3, 2024 19:34
@MarianoGnu
Copy link
Contributor Author

GHA / 📊 Static checks / Code style, file formatting, and docs (pull_request) seems to be complaining about some part of the file that was not modified by this PR (it wants to change an #include)

Copy link
Member

@RandomShaper RandomShaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Calinou Calinou added this to the 4.2 milestone Jul 3, 2024
@akien-mga
Copy link
Member

I pushed a fix for the static checks issue in the 4.2 branch, it should solve the problem if you rebase.

master branch has changed too much from 4.2.x to make a pull request to it tho

Is the master branch affected by that issue though?

There's little point in fixing a bug in 4.2 only if we're about to release 4.3 with the same bug.

@akien-mga akien-mga changed the title [4.2.x] Make an early return when rendering buffer failed to allocate instead… [4.2] Make an early return when rendering buffer failed to allocate instead… Jul 5, 2024
@akien-mga
Copy link
Member

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

@RandomShaper
Copy link
Member

Also, regarding 4.3+ all those error checks are performed driver-agnostically at RenderingDevice, so there's no need to forward-port anything.

@MarianoGnu MarianoGnu force-pushed the 4.2-vulkan-out-of-memory-error-fix branch from 6590e72 to 93fa217 Compare July 5, 2024 18:20
@MarianoGnu MarianoGnu force-pushed the 4.2-vulkan-out-of-memory-error-fix branch from 93fa217 to 63be8ec Compare July 5, 2024 18:34
@MarianoGnu
Copy link
Contributor Author

I pushed a fix for the static checks issue in the 4.2 branch, it should solve the problem if you rebase.

Rebased

For the record, your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

Fixed

@akien-mga akien-mga merged commit e55db90 into godotengine:4.2 Jul 7, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants