-
-
Notifications
You must be signed in to change notification settings - Fork 19.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GDScript: Add exclude_addons_exceptions
project setting
#93889
base: master
Are you sure you want to change the base?
GDScript: Add exclude_addons_exceptions
project setting
#93889
Conversation
Bit of an iffy spot to use raw file paths to the I get we are extremely limited when it comes to UI design here, but this kind of setting would make a whole lot more sense if it was available in the Addons tab as a toggle for each addon, instead. Problem is, this is a bit too specific to deserve a special column, and hiding it behind an "Others" secion would make it too obscure. I think it would feel a whole lot more natural, beneficial, and encompassing to have both an exclusion list (blacklist) and inclusion list (whitelist, or exceptions as by this PR) of folder/file paths where warnings can apply. |
@Mickeon I thought about both options and initially implemented the Debug column in the Plugins tab. But after some thought, I decided that this was an overcomplication. You have only two types of code in your project: your own (including some plugins) and third-party. For your own code, you should stick to a consistent style and warning configuration. If you want to suppress some warnings at the individual file level, there is The option of excluding arbitrary folders or |
23b7636
to
a6211d0
Compare
From a UX perspective, plugins created through the create plugin wizard should be added to this setting automatically, since they are obviously code of the current user. Also I'd only show the note in the configuration dialog, when the plugin is not on the list, otherwise users might make an unnecessary trip to the settings just to find the plugin already configured. |
@HolonProduction Thanks for the comment! I thought about this option, but there are a few questions we should discuss first:
|
|
exclude_addons
.NATIVE_METHOD_OVERRIDE
). The lack of warnings/errors for actively developed addons is confusing.