Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AnimationMixer docs example code for get_root_motion_rotation_accumulator #93855

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

ayanchavand
Copy link
Contributor

Fixes #93821
-Changed get_root_motion_Quaternion_accumulator to get_root_motion_rotation_accumulator
-Changed transform.basis *= difference to transform.basis *= Basis(difference)

@ayanchavand ayanchavand requested a review from a team as a code owner July 2, 2024 07:39
@Chaosus Chaosus added this to the 4.3 milestone Jul 2, 2024
@akien-mga akien-mga requested a review from a team July 2, 2024 10:53
@akien-mga akien-mga changed the title Fix: AnimationMixer Docs Example Code for get_root_motion_rotation_accumulator ( ) Fix AnimationMixer docs example code for get_root_motion_rotation_accumulator Jul 2, 2024
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Jul 2, 2024
@akien-mga akien-mga merged commit 9db1a96 into godotengine:master Jul 2, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incremental root motion rotation will produce a wrong locomotion
5 participants