Vulkan Volumetric Fog Issue #93833
Vulkan Volumetric Fog Issue #93833
Conversation
| @@ -286,11 +288,17 @@ void RendererViewport::_draw_viewport(Viewport *p_viewport) { | |||
| // The scene renderer will still copy over the last frame, so we need to clear the render target. | |||
| force_clear_render_target = true; | |||
| } | |||
|
|
|||
| // Calculate the frames needed for volumetric fog to converge. | |||
| if (p_viewport->size != p_viewport->old_size && can_draw_3d) { | |||
There was a problem hiding this comment.
Resizing the viewport is not the only thing that can require reconverging volumetric fog.
A lot of other things can require redrawing for the volumetric fog preview to remain accurate. In order of importance (from most to least important):
- Toggling volumetric fog or changing one of its properties.
- Hiding or showing a FogVolume node, or changing one of its material properties.
- Hiding or showing a light that effects volumetric fog, or changing one of its properties.
- Hiding or showing a mesh that blocked a light (through shadows), and where the shadow was visible in the volumetric fog.
This is a lot to keep track of, so it might be better to always redraw for the volumetric fog duration whenever volumetric fog is enabled. We should try to do this only if something 3D-related happened though, so that UI-only updates do not force a full redraw of both 2D and 3D (they are always drawn at the same time).
Also, we'll need several other things that keep track of a "frames needed" variables in the future, such as:
- Temporal antialiasing/FSR2 (8 frames for TAA, variable for FSR2 according to the viewport's 3D resolution scale).
- SSIL (1 frame delay after a viewport resize).
- SDFGI (30 frames delay, adjustable in project settings).
You don't need to implement these in this PR; it's just a note for later to make sure we don't need to copy-paste too much code around.
|
You used a merge commit to update your branch, please use rebase in the future instead, see here |
Issue: godotengine#62794 This fix calculates the number of frames needed, based on the temporal reprojection amount, to redraw until the volumetric fog fully converges.
Mantle-Core
force-pushed
the
vulkan-volumetric-fog-issue
branch
from
77e3d68
to
ba90f69
Compare
Issue
Fixes #62794
Godot version
4.x
System information
Description
This fix calculates the number of frames needed, based on the temporal reprojection amount, to redraw until the volumetric fog fully converges.
Note: Another issue related to the flickering when adjusting the viewport has already been addressed.
Changes Made
int frames_needed;: Stores the number of frames needed for the volumetric fog to converge.Size2i old_size;: Stores the previous size of the viewport. Used to check if the viewport was resized.Additional Information
Volume.Fog.mp4