Include "PopupMenu" labels in POT gen #93521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblackburn
changed the title
YeldhamDev
added
enhancement
topic:editor
cherrypick:4.3
|
This also includes ItemList. |
YeldhamDev
approved these changes
Jun 24, 2024
|
@KoBeWi So it does, looks like they share the same format. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating the POT file, text labels given to
PopupMenuitems were not being detected as translatable strings. I found that these appear to be serialized as:After some digging i found that adding
item_*/texttolookup_propertiesresults in them being added to the generated template.