Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PO plural translation rules handling. #93262

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Improve PO plural translation rules handling. #93262

merged 1 commit into from
Jun 18, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 17, 2024

Fixes #93208

@bruvzg bruvzg added this to the 4.3 milestone Jun 17, 2024
@bruvzg bruvzg mentioned this pull request Jun 17, 2024
Closed
@bruvzg bruvzg changed the title Improve PR plural translation rules handling. Improve PO plural translation rules handling. Jun 17, 2024
@bruvzg bruvzg force-pushed the po_expr_tree branch 2 times, most recently from 596afc8 to 3a2296f Compare June 17, 2024 17:29
@bruvzg bruvzg marked this pull request as ready for review June 18, 2024 05:37
@bruvzg bruvzg requested a review from a team as a code owner June 18, 2024 05:37
AThousandShips
AThousandShips approved these changes Jun 18, 2024
View reviewed changes
core/string/translation_po.cpp Outdated Show resolved Hide resolved
@akien-mga akien-mga merged commit 344ab04 into godotengine:master Jun 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug topic:core
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Multiple gettext plural forms in tr_n() have unexpected results
3 participants
@bruvzg @akien-mga @AThousandShips