Allow theming renderer colors #93229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
reviewed
Jun 16, 2024
editor/editor_node.cpp
Outdated
| @@ -7117,6 +7114,8 @@ EditorNode::EditorNode() { | |||
| renderer->set_focus_mode(Control::FOCUS_NONE); | |||
| renderer->set_tooltip_text(TTR("Choose a rendering method.\n\nNotes:\n- On mobile platforms, the Mobile rendering method is used if Forward+ is selected here.\n- On the web platform, the Compatibility rendering method is always used.")); | |||
|
|
|||
| callable_mp(this, &EditorNode::_update_renderer_color).call_deferred(); | |||
There was a problem hiding this comment.
I've never seen this form of using call_deferred() in C++ before, but I guess it makes sense to avoid String usage. We should probably start using it in other places too.
akien-mga
reviewed
Jun 17, 2024
passivestar
force-pushed
the
themable-renderer-colors
branch
from
d75d5ff
to
e0ab91a
Compare
akien-mga
approved these changes
Jun 17, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were already exposed to theming but unused in code
Slightly brighter colors in a theme: