Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Input use GetKeyState instead of GetAsyncKeyState #93105

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Windows Input use GetKeyState instead of GetAsyncKeyState #93105

merged 1 commit into from
Jun 13, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Jun 12, 2024

The GetKeyState docs don't mention mouse keys unlike GetAsyncKeyState, but it seems to work fine.

@kitbdev kitbdev requested a review from a team as a code owner June 12, 2024 22:41
@kitbdev kitbdev mentioned this pull request Jun 12, 2024
Closed
@kitbdev kitbdev changed the title Input use GetKeyState instead of GetAsyncKeyState Windows Input use GetKeyState instead of GetAsyncKeyState Jun 12, 2024
@bruvzg bruvzg self-requested a review June 13, 2024 05:06
@bruvzg
Copy link
Member

bruvzg commented Jun 13, 2024

The GetKeyState docs don't mention mouse keys unlike GetAsyncKeyState, but it seems to work fine.

Mouse buttons are mentioned on the Virtual-Key Codes page linked on the GetKeyState page, and since there are no remarks about these keys, it is safe to assume it is fully supported.

@bruvzg bruvzg added this to the 4.3 milestone Jun 13, 2024
@alvinhochun
Copy link
Contributor

Tested and yep, this does seem to fix the issue. Thanks.

@akien-mga akien-mga merged commit 2fab2c7 into godotengine:master Jun 13, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the keystate branch June 13, 2024 13:35
@bruvzg bruvzg mentioned this pull request Jun 16, 2024
Closed
@kitbdev kitbdev mentioned this pull request Jul 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug platform:windows topic:input
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Dragging mouse to select text in script editor may randomly change selection range and trigger drag
4 participants
@kitbdev @bruvzg @alvinhochun @akien-mga