Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Hide GDScript internal functions from method selectors #92802

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Editor: Hide GDScript internal functions from method selectors #92802

merged 1 commit into from
Jun 7, 2024

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Jun 5, 2024

Hide @methods in the editor (Connection Dialog and Method Selector). This is option 2.1 from #92782 (comment).

@dalexeev dalexeev added this to the 4.3 milestone Jun 5, 2024
@dalexeev dalexeev requested a review from a team June 5, 2024 15:28
AThousandShips
AThousandShips approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good and I think this is the best option for this at least for the time being, with the option of breaking compatibility down the line

@akien-mga akien-mga merged commit 31b55e7 into godotengine:master Jun 7, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@dalexeev dalexeev deleted the editor-hide-gdscript-internal-funcs branch June 7, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug discussion topic:editor topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Signal can't be connected to variable setter.
3 participants
@dalexeev @akien-mga @AThousandShips