[3.x] Faster editor grid #92725
Merged
[3.x] Faster editor grid #92725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use static `LocalVectors` instead of `PoolVectors` for temporaries.
|
Sounds great – this should help reduce CPU bottlenecks and improve battery life when working in 3D. Is a similar optimization possible in 4.x? |
It may not be as bad there, as it is using The other factor with the grid is the rendering churn (which I'm sure we've mentioned as an inefficiency before), it should be using dynamic VBs for this kind of thing and I have a feeling it's recreating VBs each frame, but it's a while since I looked at that. |
clayjohn
approved these changes
Jun 12, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use static
LocalVectorsinstead ofPoolVectorsfor temporaries.Notes
_init_grid()taking a long time in some editor profiles when moving the 3D viewport (40% CPU)._init_grid()(aside from the renderer churn) is currently bottlenecked byPoolVectorallocations and thread safety duringpush_back()._init_grid()approx 8x faster (not very rigorous, based on profiles, but certainly a lot faster), based on a pretty simple change, so why not.