Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiler seek line color in light modes, update on theme change #92389

Merged
merged 1 commit into from
May 28, 2024

Conversation

ckaiser
Copy link
Contributor

@ckaiser ckaiser commented May 26, 2024

Fixed the profiler seek line being basically invisible in light modes, also added a call to _update_plot() to force it to redraw when changing themes, since otherwise it'd get stuck with the old colors until there was any activity.

Before:
image

After:
image

@ckaiser ckaiser requested a review from a team as a code owner May 26, 2024 17:34
@Chaosus Chaosus added this to the 4.3 milestone May 26, 2024
@Calinou
Copy link
Member

Calinou commented May 26, 2024

Tested locally, it works as expected:

simplescreenrecorder-2024-05-26_20.40.53.mp4

Note that the Visual Profiler doesn't update any of its colors when the theme changes. It might be worth looking into this in a separate PR 🙂

@akien-mga akien-mga merged commit 7d772e7 into godotengine:master May 28, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants