Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix coremidi device index issues #92256

Closed
wants to merge 7 commits into from
Closed

Fix coremidi device index issues #92256

wants to merge 7 commits into from
+3 −3

Commits on May 22, 2024

  1. fix for coremidi device index issues 

    previously it was passing the pointer to i, which would be out of scope when events came in to ::read. We actually need to use the void *  to hold the value of i, not a reference to i. Using reinterpret to overcome platform issues.  NOTE :  not tested as no suitable build environment here
    @ramdor
    ramdor committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c5cebf0 View commit details
    Browse the repository at this point in the history

  2. Update midi_driver_coremidi.cpp 

    small tweak for possible loss of data warning
    @ramdor
    ramdor committed May 22, 2024
    Configuration menu
    Copy the full SHA
    1ce6516 View commit details
    Browse the repository at this point in the history

  3. final tidy up 

    remove casts from loop
    @ramdor
    ramdor committed May 22, 2024
    Configuration menu
    Copy the full SHA
    cbec5e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. Merge branch 'godotengine:master' into coremidi-device_index-fix

    @ramdor
    ramdor authored Jun 4, 2024
    Configuration menu
    Copy the full SHA
    39321d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2024

  1. Merge branch 'godotengine:master' into coremidi-device_index-fix

    @ramdor
    ramdor authored Jun 12, 2024
    Configuration menu
    Copy the full SHA
    ef1ef93 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2024

  1. Merge branch 'godotengine:master' into coremidi-device_index-fix

    @ramdor
    ramdor authored Jun 14, 2024
    Configuration menu
    Copy the full SHA
    9132e6c View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Merge branch 'godotengine:master' into coremidi-device_index-fix

    @ramdor
    ramdor authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    3b7037d View commit details
    Browse the repository at this point in the history