Stereo rendering: Fix omni lights #92186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BastiaanOlij
added
bug
topic:rendering
topic:xr
topic:3d
cherrypick:4.2
|
@clayjohn I think this could use a rework at some point so that we rebind the correct uniform buffers after we perform the sky process, but for now I've solved it the same way this was already solved for the conflict with |
|
#82278 might be the same issue, does this fix it too? |
|
Can confirm this fixes the issue!
|
clayjohn
approved these changes
May 21, 2024
|
Awesome debugging, been troubled by this as well. |
BastiaanOlij
force-pushed
the
fix_stereo_omni_lights
branch
from
10d389d
to
db32707
Compare
akien-mga
added
the
cherrypick:4.1
|
Thanks! @BastiaanOlij I see you flagged this for a 4.2 cherrypick, which makes sense. Do you think it would also cherry-pick and work properly for 4.1? |
|
@akien-mga I think this has been in there for a long time so probably yes, but I think someone might want to test that hypothesis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one was super dumb.
Turns out setting stereo rendering for sky set uniform location 5 to the uniform buffer containing Multiview data for the sky.
Geometry rendering however uses this to access the omni light buffer.
The result is that the rendering was accessing the incorrect data.