-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ctrl + R keyboard shortcut to restart particle emission in the editor #92134
Add Ctrl + R keyboard shortcut to restart particle emission in the editor #92134
Conversation
fb4536d
to
b72b45e
Compare
Is ctrl+space available? I'd like to have a shortcut to pause particles as well. So play/pause, restart, and frameskip too (, and . probably for frameskip) |
Particle pausing can be implemented by toggling Speed Scale between its previous value and The same goes for frameskip once seeking is implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should define the shortcut once and use ED_GET_SHORTCUT.
I tried to do that in EditorNode's constructor, but I got "unknown shortcut" errors when I select a particles node. |
@Calinou yep! for now pause doesn't make sense, but i mentioned it in case we can reserve it ^^ |
It should work if you define them right after EditorSettings are created. Lines 6295 to 6298 in aaa4560
|
I've amended the PR with this change, thanks 🙂 |
b72b45e
to
0109de7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will conflict with #92223
Needs rebase after #92223. |
0109de7
to
a7c9a6f
Compare
…itor Restarting particle animation frequently is often done in the VFX tweaking process. This shortcut is available for both GPUParticles and CPUParticles, in 2D and 3D.
a7c9a6f
to
57f5209
Compare
Thanks! |
Restarting particle animation frequently is often done in the VFX tweaking process.
This shortcut is available for both GPUParticles and CPUParticles, in 2D and 3D.
Ctrl + R is currently only used in the script editor, so we can safely use it in the 2D/3D editors.