Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix incorrect executable perms #92053

Merged
merged 1 commit into from
May 18, 2024

Conversation

Repiteo
Copy link
Contributor

@Repiteo Repiteo commented May 17, 2024

Swept through the repo & applied chmod fixes to files that either erroneously lacked execution perms (shell/python scripts w/ shebang) or erroneously had execution perms (some third party .h/.cpp files for some reason).

@akien-mga
Copy link
Member

I don't think the shell completion files should have executable permission.

At least on my system (Fedora 40) the bash completion files in /usr/share/bash-completion/completions/ are 0644.

The rest looks good.

@akien-mga akien-mga added this to the 4.3 milestone May 17, 2024
@akien-mga akien-mga merged commit 337e5da into godotengine:master May 18, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@Repiteo Repiteo deleted the ci/exec-perm-fixes branch May 18, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants