Fix TileMap selection pattern being needlessly reorganized #91905
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53901
This PR removes some processing that aimed to fix the TileMap editor selection when switching layer, tabs, etc. But I believe it's probably too safe. So I replaced it by something that seems to make more sense to me.
Note that the editor will keep the pattern even if you change TileSet (so, like, the pattern will be the same but using another TileSet, if that's clear). That might be a bit weird but it does not cause any error, so I did not bother fixing that by keeping an reference of the edited TileSet in the editor.
I didn't spot any obvious regressions by this change, but there might be some situations where the removal of those "too safe" operations might lead to some small regressions.