Revert premul alpha to spell without the T #91399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 1, 2024
akien-mga
changed the title
material.cpp and docs
QbieShay
force-pushed
the
qbe/fix-pmul-name
branch
from
4e97b58
to
b6c25b3
Compare
akien-mga
approved these changes
May 1, 2024
QbieShay
force-pushed
the
qbe/fix-pmul-name
branch
from
b6c25b3
to
9b10f99
Compare
Geometror
approved these changes
May 1, 2024
QbieShay
force-pushed
the
qbe/fix-pmul-name
branch
from
9b10f99
to
9f099b5
Compare
QbieShay
changed the title
material.cpp and docs
clayjohn
reviewed
May 1, 2024
QbieShay
force-pushed
the
qbe/fix-pmul-name
branch
from
9f099b5
to
db06397
Compare
Initially 3d had premulT alpha as a keyword. Since Canvas item uses mixed premul and premult as keywords, 3D is changed as well to keep consistency with 2D. Unfortunately this keeps inconsistency with the internal ENUM.
QbieShay
force-pushed
the
qbe/fix-pmul-name
branch
from
db06397
to
e410643
Compare
clayjohn
approved these changes
May 1, 2024
There was a problem hiding this comment.
Looks great. We now need add blend_premul_alpha and PREMUL_ALPHA to the spatial shader docs https://docs.godotengine.org/en/latest/tutorials/shaders/shader_reference/spatial_shader.html
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #85609
Changed naming back to keep (in)consistencies with 2D.