Update the description and parameter name for Vector3 reflect to correct how the plane is constructed #91376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the comment in #89404 (comment)
The previous name/description was wrong. While describing the plane as a direction seemed convenient. It doesn't make sense in practice since a direction can be used to create an infinite number of planes (by rotating on that axis). Calling the param a normal is more correct.
When describing the parameter as a normal, we have to be very careful to distinguish between reflection and bouncing as the words in plain English essentially mean the same thing.
CC @aaronfranke What do you think?