-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show in filesystem option for file favorites #91158
Merged
akien-mga
merged 1 commit into
godotengine:master
from
Arnklit:show-in-filesystem-favorites
Apr 26, 2024
Merged
Add show in filesystem option for file favorites #91158
akien-mga
merged 1 commit into
godotengine:master
from
Arnklit:show-in-filesystem-favorites
Apr 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Apr 25, 2024
mihe
suggested changes
Apr 25, 2024
mihe
reviewed
Apr 25, 2024
Arnklit
force-pushed
the
show-in-filesystem-favorites
branch
from
April 25, 2024 15:17
a7c3019
to
c94411a
Compare
Sorry created another formatting issue. I'll get them sorted and install those pre-commit hooks. |
Arnklit
force-pushed
the
show-in-filesystem-favorites
branch
from
April 26, 2024 08:03
c94411a
to
ca2005f
Compare
mihe
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me (whatever that's worth) from a code perspective.
akien-mga
approved these changes
Apr 26, 2024
AThousandShips
approved these changes
Apr 26, 2024
Thanks! |
Nice ! Might be worth adding a custom shortcut setting for this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "Show in FileSystem" option for favorited files.
godot.windows.editor.x86_64_pya76Mk6bS.mp4
Shoutout @mihe for helping me out with this.