Fix SubViewport/AudioStreamPlayer2D crash
#91123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good to rebase to get a new CI run. The previous one failed, but the logs have expired so we don't know why. |
Updated Viewport destructor to remove itself from World2D, to avoid World2D keeping invalid pointers.
aaronp64
force-pushed
the
multi_viewport_crash
branch
from
f66a50d
to
7a9acd5
Compare
|
Rebased, looks like checks are ok now. I think the original failure might have been due to separate build issues that day, possibly related to #91120 |
akien-mga
approved these changes
Sep 3, 2024
akien-mga
added
the
cherrypick:4.3
|
Thanks! |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
Viewportdestructor to remove itself fromWorld2D, to avoidWorld2Dkeeping invalid pointers.Fixes #89212
Fixes #91796