SCons: scons_version to environment variable
#91080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauermann
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
Have tested the PR rebased on c7f56d3
System: Debian GNU/Linux 12 (bookworm) 12 - X11 - GLES3 (Compatibility) - NVIDIA - AMD
Can confirm, that with these changes I can compile Godot again.
Can't say anything about the implementation.
|
We tend to spell out words so I expected to see "scons_ver" -> "scons_version". Comments? |
akien-mga
approved these changes
Apr 24, 2024
akien-mga
changed the title
scons_ver to environment variablescons_version to environment variable
akien-mga
force-pushed
the
scons/scons_ver-variable
branch
from
3addec8
to
fd2ab72
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes uncertainty of
_get_major_minor_revisionas a static method by making a call viaenvlike before. Instead of it being locked to a local call, it's now treated as a property ofenvto allow it to be called across multiple scripts if needed.