Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't translate ColorPicker color labels #90869

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Apr 18, 2024

Prevents this

@KoBeWi KoBeWi added this to the 4.3 milestone Apr 18, 2024
@KoBeWi KoBeWi requested a review from a team as a code owner April 18, 2024 18:30
@timothyqiu
Copy link
Member

An alternate solution is to use context for these labels, something like ETR("B", "Color Channel").

@KoBeWi
Copy link
Member Author

KoBeWi commented Apr 19, 2024

Is translating "RGB" even a thing? I never seen a software that does it.

@akien-mga
Copy link
Member

Btw, we should likely add translation context to the other ETR("B") regardless of this change. (And the other kB, MB, etc. for consistency.)

@timothyqiu
Copy link
Member

Is translating "RGB" even a thing? I never seen a software that does it.

I've never seen that either. Maybe some languages do that. Just checked GIMP does i18n for R, G, and B for its colorpicker.

https://github.com/GNOME/gimp/blob/97d6aa59044c44d0bdf934e7174d6c61abdbfd6d/libgimpwidgets/gimpwidgetsenums.c#L130-L140

@AThousandShips
Copy link
Member

AThousandShips commented Apr 19, 2024

At least the Wikipedia page has the acronym translated and not just transcribed in some languages, so I think there's room for it, and it'd at least be transcribed in languages using Cyrillic for example

@dalexeev
Copy link
Member

I can imagine КЗС (красный, зелёный, синий) in Russian localization, but I think that most often RGB is not translated. On the other hand, providing context will allow translators of each locale to decide whether to translate it or not.

@KoBeWi
Copy link
Member Author

KoBeWi commented Apr 19, 2024

How to add localization for labels if they are constant strings stored in a raw array? It would require some rewrite of color modes.

@timothyqiu
Copy link
Member

How to add localization for labels if they are constant strings stored in a raw array? It would require some rewrite of color modes.

That could be a separate PR.

@akien-mga akien-mga merged commit f0db317 into godotengine:master Apr 22, 2024
16 checks passed
@KoBeWi KoBeWi deleted the babe_wake_up,_new_color_space_just_dropped branch April 22, 2024 11:02
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants