Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDScript: Fix some export annotation issues #90716

Merged

Conversation

dalexeev
Copy link
Member

@dalexeev dalexeev commented Apr 15, 2024

  • Add missing static variable check for @export_custom.
  • Move the @export_storage implementation into a separate method and add a comment about the reasons.
  • Document that PROPERTY_USAGE_SCRIPT_VARIABLE flag is always added.
  • Fix Editor Help displaying rough types for annotation arguments.
  • Add autocompletion for @export_custom arguments.
  • Resolve Incoherent Property hint_string with Array #89816 (don't add property_hint for PROPERTY_HINT_NONE).
  • Fix class_name and usage for enum arrays, improve utils.notest.gd to track changes in tests.
  • Add more test cases in export_variable.gd.

@dalexeev dalexeev added this to the 4.3 milestone Apr 15, 2024
@dalexeev dalexeev force-pushed the gds-fix-export-annotation-issues branch from 153b8fa to 8009122 Compare April 15, 2024 19:30
@dalexeev dalexeev force-pushed the gds-fix-export-annotation-issues branch 3 times, most recently from 684360f to a6e2c1b Compare May 13, 2024 13:52
@dalexeev dalexeev force-pushed the gds-fix-export-annotation-issues branch from a6e2c1b to 76b2d85 Compare May 13, 2024 14:49
@dalexeev dalexeev marked this pull request as ready for review May 13, 2024 14:49
@dalexeev dalexeev requested a review from a team as a code owner May 13, 2024 14:49
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akien-mga akien-mga merged commit 6761923 into godotengine:master May 19, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incoherent Property hint_string with Array
3 participants