OpenXR: Apply fix for reverse Z #90416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
Thanks!
I haven't tested, but this change looks good, and matches what the spec says about supporting reverse z:
akien-mga
changed the title
|
Needs rebase. |
BastiaanOlij
force-pushed
the
openxr_fix_reverse_z
branch
from
f73e854
to
b67eba8
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to feedback we've received from the OpenXR group, this should be the right way to handle reverse-Z in OpenXR.
This only applies if the depth buffer is submitted to OpenXR, something that not all XR runtimes actually utilise (it's used for advanced reprojection if it is). This option is disabled by default and needs to be enabled if users want to try it out.
I tested this on:
Both with mobile and compatibility renderer. All seemed to work fine except SteamVR on compatibility giving a black screen. I've however verified that this is an existing problem unrelated to reverse-Z or this fix which should be investigated separately..