Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix built-in FileDialog appearing instead of the native one on some cases #90318

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

YeldhamDev
Copy link
Member

If a FileDialog that's supposed to be native starts visible, or is set to be native while visible, the built-in version would not just still remain there, but attempting to close it would make both versions be on-screen. This PR fixes those cases.

@YeldhamDev YeldhamDev added this to the 4.3 milestone Apr 6, 2024
@YeldhamDev YeldhamDev requested a review from a team as a code owner April 6, 2024 19:00
@akien-mga akien-mga requested a review from bruvzg April 6, 2024 19:33
@akien-mga akien-mga merged commit bca2c30 into godotengine:master Apr 8, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@YeldhamDev YeldhamDev deleted the not_native_enough branch April 8, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants